Bug 130484

Summary: [Webkit2] Add APIDownloadClient for download support.
Product: WebKit Reporter: Yongjun Zhang <yongjun_zhang>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, bunhere, cdumez, commit-queue, gyuyoung.kim, mitz, rakuco, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch.
andersca: review+
[Webkit2] Add APIDownloadClient for download support. none

Yongjun Zhang
Reported 2014-03-19 16:15:39 PDT
For download support, we need to add API::DownloadClient and make the existing WebDownloadClient subclass to it. This is to follow the new pattern for API classes.
Attachments
Patch. (30.54 KB, patch)
2014-03-19 16:24 PDT, Yongjun Zhang 		andersca: review+
DetailsFormatted DiffDiff
[Webkit2] Add APIDownloadClient for download support. (31.85 KB, patch)
2014-03-21 13:35 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2014-03-19 16:24:40 PDT
Created attachment 227230 [details] Patch.
Andy Estes
Comment 2 2014-03-21 13:35:30 PDT
Created attachment 227483 [details] [Webkit2] Add APIDownloadClient for download support.
WebKit Commit Bot
Comment 3 2014-03-21 13:36:16 PDT
Attachment 227483 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/APIDownloadClient.h:64: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIDownloadClient.h:64: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 4 2014-03-21 13:37:10 PDT
Somehow I missed Yongjun posting a patch, and I ended up writing an almost exact copy of it :( Sorry.
Anders Carlsson
Comment 5 2014-03-21 13:58:55 PDT
Comment on attachment 227230 [details] Patch. Looks very good, but the WebContext constructor needs to initialize m_downloadClient, something like: , m_downloadClient(std::make_unique<API::DownloadClient>())
Andy Estes
Comment 6 2014-03-21 14:15:22 PDT
Committed r166096: <http://trac.webkit.org/changeset/166096>
Note You need to log in before you can comment on or make changes to this bug.