Bug 130481

Summary: Win64 needs some love
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Attachments:
Description Flags
Patch bfulgham: review+, commit-queue: commit-queue-

Alex Christensen
Reported 2014-03-19 15:02:30 PDT
Just some maintenance. I noticed the AppleWin port isn't building the WebInspectorUI project, but I didn't fix it in case there's a reason for that.
Attachments
Patch (10.31 KB, patch)
2014-03-19 15:04 PDT, Alex Christensen 		bfulgham: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-03-19 15:04:29 PDT
Created attachment 227223 [details] Patch
Brent Fulgham
Comment 2 2014-03-20 13:39:55 PDT
Comment on attachment 227223 [details] Patch Looks good. We should building WebInspectorUI, so go ahead and add it in the future.
WebKit Commit Bot
Comment 3 2014-03-20 13:43:08 PDT
Comment on attachment 227223 [details] Patch Rejecting attachment 227223 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/TestController.o TestController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/PlatformWebViewMac.o mac/PlatformWebViewMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (2 failures) Full output: http://webkit-queues.appspot.com/results/5284991248367616
Alex Christensen
Comment 4 2014-03-20 13:49:49 PDT
http://trac.webkit.org/changeset/165994
Note You need to log in before you can comment on or make changes to this bug.