Bug 130476

Summary: Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Simon Fraser (smfr)
Reported 2014-03-19 14:26:51 PDT
Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
Attachments
Patch (8.36 KB, patch)
2014-03-19 14:28 PDT, Simon Fraser (smfr) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-03-19 14:28:59 PDT
Created attachment 227217 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-19 14:30:55 PDT
Attachment 227217 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:111: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:112: Missing spaces around = [whitespace/operators] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-03-19 15:05:56 PDT
Comment on attachment 227217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227217&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:247 > + return [self currentZoomFactor] * DefaultZoomFactorRatio < DefaultMaximumZoomFactor; dot syntax. > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:261 > + return [self currentZoomFactor] / DefaultZoomFactorRatio > DefaultMinimumZoomFactor; dot syntax.
Simon Fraser (smfr)
Comment 4 2014-03-19 16:45:21 PDT
https://trac.webkit.org/r165930
Note You need to log in before you can comment on or make changes to this bug.