| Summary: | Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, mitz, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-03-19 14:26:51 PDT
Created attachment 227217 [details]
Patch
Attachment 227217 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:111: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:112: Missing spaces around = [whitespace/operators] [4]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 227217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227217&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:247 > + return [self currentZoomFactor] * DefaultZoomFactorRatio < DefaultMaximumZoomFactor; dot syntax. > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:261 > + return [self currentZoomFactor] / DefaultZoomFactorRatio > DefaultMinimumZoomFactor; dot syntax. |