Bug 130468

Summary: Webkit2 builds are forced with CMake, if Gtk+3 is used
Product: WebKit Reporter: Tomeu Vizoso <tomeu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bunhere, cgarcia, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+, mrobinson: commit-queue-

Tomeu Vizoso
Reported 2014-03-19 10:34:04 PDT
Maybe I'm missing something, because I don't see the logic behind this.
Attachments
Patch (1.20 KB, patch)
2014-03-19 10:41 PDT, Tomeu Vizoso 		mrobinson: review+
mrobinson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomeu Vizoso
Comment 1 2014-03-19 10:41:20 PDT
Created attachment 227196 [details] Patch
Martin Robinson
Comment 2 2014-03-22 20:44:50 PDT
Comment on attachment 227196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227196&action=review > Source/cmake/OptionsGTK.cmake:114 > + if (ENABLE_WEBKIT2) > + set(ENABLE_PLUGIN_PROCESS ON) > + endif () Small nit. This doesn't need to be inside the if (NOT USE_GTK2) block
Martin Robinson
Comment 3 2014-09-16 10:18:54 PDT
WebKit1 is gone now.
Note You need to log in before you can comment on or make changes to this bug.