Bug 130468

Summary:

Webkit2 builds are forced with CMake, if Gtk+3 is used

Product:

WebKit

Reporter:

Tomeu Vizoso <tomeu>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bunhere, cgarcia, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+, mrobinson: commit-queue-

Description Tomeu Vizoso 2014-03-19 10:34:04 PDT

Maybe I'm missing something, because I don't see the logic behind this.

Comment 1 Tomeu Vizoso 2014-03-19 10:41:20 PDT

Created attachment 227196 [details]
Patch

Comment 2 Martin Robinson 2014-03-22 20:44:50 PDT

Comment on attachment 227196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227196&action=review

> Source/cmake/OptionsGTK.cmake:114
> +    if (ENABLE_WEBKIT2)
> +        set(ENABLE_PLUGIN_PROCESS ON)
> +    endif ()

Small nit. This doesn't need to be inside the if (NOT USE_GTK2) block

Comment 3 Martin Robinson 2014-09-16 10:18:54 PDT

WebKit1 is gone now.