Bug 130454

Summary:

[ARM64] GNU assembler fails in TransformationMatrix::multiply

Product:

WebKit

Reporter:

Gabor Rapcsanyi <rgabor>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, ossy, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Bug Depends on:

Bug Blocks:

108645, 130506

Attachments:

Description	Flags
proposed fix	none

Description Gabor Rapcsanyi 2014-03-19 08:03:19 PDT

/tmp/ccqXY1vB.s:62: Error: unknown mnemonic `fmul.2d' -- `fmul.2d v28,v24,v16'
/tmp/ccqXY1vB.s:63: Error: unknown mnemonic `fmul.2d' -- `fmul.2d v29,v24,v17'
/tmp/ccqXY1vB.s:64: Error: unknown mnemonic `fmla.2d' -- `fmla.2d v28,v25,v18'
/tmp/ccqXY1vB.s:65: Error: unknown mnemonic `fmla.2d' -- `fmla.2d v29,v25,v19'

Comment 1 Gabor Rapcsanyi 2014-03-19 08:15:22 PDT

Created attachment 227184 [details]
proposed fix

Comment 2 Zoltan Herczeg 2014-03-24 01:30:21 PDT

This is also looks sane. If noone has any objection, we can refactor this as well.

Comment 3 Zoltan Herczeg 2014-03-25 05:44:53 PDT

Comment on attachment 227184 [details]
proposed fix

This should work. r=me.

Comment 4 WebKit Commit Bot 2014-03-25 06:15:09 PDT

Comment on attachment 227184 [details]
proposed fix

Clearing flags on attachment: 227184

Committed r166233: <http://trac.webkit.org/changeset/166233>

Comment 5 WebKit Commit Bot 2014-03-25 06:15:13 PDT

All reviewed patches have been landed.  Closing bug.