Summary: | Filter out editable services from image menu for non-contenteditable images | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2014-03-18 17:41:05 PDT
Created attachment 227188 [details]
Patch v1
Comment on attachment 227188 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55 > +- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient Is the list of things to exclude likely to expand? If so, we might want to consider doing something different here. (In reply to comment #2) > (From update of attachment 227188 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55 > > +- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient > > Is the list of things to exclude likely to expand? If so, we might want to consider doing something different here. I don't predict the list expanding. That said, I'm comfortable with the principal of doing it this way for the one known thing, then if a second thing comes up later we can reassess. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 227188 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review > > > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55 > > > +- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient > > > > Is the list of things to exclude likely to expand? If so, we might want to consider doing something different here. > > I don't predict the list expanding. > > That said, I'm comfortable with the principal of doing it this way for the one known thing, then if a second thing comes up later we can reassess. Yeah, that's fine. |