Bug 130427 – [iOS][WebKit2] Mark layer contents as being opaque if they are

• Component: WebKit2
• Status: RESOLVED FIXED

[Tim Horton]

<rdar://problem/15540434>

[Tim Horton]

Created attachment 227141 [details]
patch

[WebKit Commit Bot]

Attachment 227141 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h:66:  The parameter name "layer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 227141 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227141&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:793
> +            if (const RemoteLayerBackingStore* backingStore = layerProperties.backingStore.get())

we should log something if it goes away too...

[Simon Fraser (smfr)]

Comment on attachment 227141 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227141&action=review

> Source/WebCore/platform/graphics/GraphicsLayerClient.h:91
> +    virtual bool willPaintOpaqueAtNonIntegralScale(const GraphicsLayer*) const { return false; }

This sounds like it only applies to the next paint. Maybe paintsOpaquelyAtNonIntegralScales?

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h:84
> +    RetainPtr<CGImageRef> image() const;

Does this actually need to return a RetainPtr?

[Tim Horton]

(In reply to comment #4)
> (From update of attachment 227141 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227141&action=review
> 
> > Source/WebCore/platform/graphics/GraphicsLayerClient.h:91
> > +    virtual bool willPaintOpaqueAtNonIntegralScale(const GraphicsLayer*) const { return false; }
> 
> This sounds like it only applies to the next paint. Maybe paintsOpaquelyAtNonIntegralScales?

Sure.

> > Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h:84
> > +    RetainPtr<CGImageRef> image() const;
> 
> Does this actually need to return a RetainPtr?

I think so? It creates a fresh CGImage from the ShareableBitmap. Maybe I should rename it createImageForFrontBuffer() or something.

[Tim Horton]

http://trac.webkit.org/changeset/165863