Bug 130406

Summary: Fix cue rendering test and include support for left/right alignment.
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: https://codereview.chromium.org/25155003
Attachments:
Description Flags
Patch eric.carlson: review+

Description Brent Fulgham 2014-03-18 10:44:29 PDT 
Merge Blink change https://codereview.chromium.org/25155003.
Comment 1 Brent Fulgham 2014-03-19 11:29:36 PDT 
Created attachment 227204 [details]
Patch
Comment 2 Eric Carlson 2014-03-19 11:34:30 PDT 
Comment on attachment 227204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227204&action=review

> Source/WebCore/html/track/VTTCue.cpp:618
> +    } else {
> +        ASSERT_NOT_REACHED();
>      }

Nit: I don't think the braces are necessary.
Comment 3 Brent Fulgham 2014-03-19 11:37:12 PDT 
(In reply to comment #2)
> (From update of attachment 227204 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227204&action=review
> 
> > Source/WebCore/html/track/VTTCue.cpp:618
> > +    } else {
> > +        ASSERT_NOT_REACHED();
> >      }
> 
> Nit: I don't think the braces are necessary.

OK. I'll remove!
Comment 4 Brent Fulgham 2014-03-19 12:00:55 PDT 
Committed r165905: <http://trac.webkit.org/changeset/165905>