Bug 130404

Summary: [GStreamer] Store TrackPrivateBaseGStreamer's label and language as AtomicStrings
Product: WebKit Reporter: Brendan Long <b.long>
Component: New BugsAssignee: Brendan Long <b.long>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, buildbot, calvaris, cgarcia, commit-queue, gustavo, menard, mrobinson, pnormand, rniwa, vjaquez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Brendan Long
Reported 2014-03-18 10:13:26 PDT
[GStreamer] Store TrackPrivateBaseGStreamer's label and language as AtomicStrings
Attachments
Patch (3.17 KB, patch)
2014-03-18 10:17 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (587.81 KB, application/zip)
2014-03-18 10:43 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brendan Long
Comment 1 2014-03-18 10:17:09 PDT
Created attachment 227067 [details] Patch I'm not sure if I'm allowed to use a template like this. Another option would be changing the 'String language' in getLanguageCode() to an AtomicString, or just duplicating the gst_tag_list_get_string() call..
Build Bot
Comment 2 2014-03-18 10:43:38 PDT
Comment on attachment 227067 [details] Patch Attachment 227067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6248967398490112 New failing tests: media/adopt-node-crash.html
Build Bot
Comment 3 2014-03-18 10:43:41 PDT
Created attachment 227074 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Brendan Long
Comment 4 2014-04-16 14:10:54 PDT
philn: Can I get your opinion on this? The Mac EWS failure is completely unrelated.
Philippe Normand
Comment 5 2014-04-16 23:27:39 PDT
Comment on attachment 227067 [details] Patch Looks good, thanks Brendan
WebKit Commit Bot
Comment 6 2014-04-17 13:31:40 PDT
Comment on attachment 227067 [details] Patch Clearing flags on attachment: 227067 Committed r167450: <http://trac.webkit.org/changeset/167450>
WebKit Commit Bot
Comment 7 2014-04-17 13:31:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.