| Summary: | [GStreamer] Store TrackPrivateBaseGStreamer's label and language as AtomicStrings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brendan Long <b.long> | ||||||
| Component: | New Bugs | Assignee: | Brendan Long <b.long> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | agomez, buildbot, calvaris, cgarcia, commit-queue, gustavo, menard, mrobinson, pnormand, rniwa, vjaquez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Brendan Long
2014-03-18 10:13:26 PDT
Created attachment 227067 [details]
Patch
I'm not sure if I'm allowed to use a template like this. Another option would be changing the 'String language' in getLanguageCode() to an AtomicString, or just duplicating the gst_tag_list_get_string() call..
Comment on attachment 227067 [details] Patch Attachment 227067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6248967398490112 New failing tests: media/adopt-node-crash.html Created attachment 227074 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
philn: Can I get your opinion on this? The Mac EWS failure is completely unrelated. Comment on attachment 227067 [details]
Patch
Looks good, thanks Brendan
Comment on attachment 227067 [details] Patch Clearing flags on attachment: 227067 Committed r167450: <http://trac.webkit.org/changeset/167450> All reviewed patches have been landed. Closing bug. |