Bug 130392 – [CSSRegions] Compute region ranges for children of inline blocks

• Component: CSS
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

Extend region range computation also for children of inline blocks.

[Mihnea Ovidenie]

Created attachment 227044 [details]
Patch

[Andrei Bucur]

Comment on attachment 227044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227044&action=review

> Source/WebCore/rendering/RenderFlowThread.cpp:801
> +            endRegion = startRegion;

An unsplittable box should always have startRegion == endRegion. Shouldn't this line be an assertion instead?

> Source/WebCore/rendering/RenderObject.cpp:529
> +    if (flowThread && (flowThreadState() == flowThread->flowThreadState()))

What's this change for?

[Mihnea Ovidenie]

Comment on attachment 227044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227044&action=review

>> Source/WebCore/rendering/RenderFlowThread.cpp:801
>> +            endRegion = startRegion;
> 
> An unsplittable box should always have startRegion == endRegion. Shouldn't this line be an assertion instead?

Yes, you are right :)

>> Source/WebCore/rendering/RenderObject.cpp:529
>> +    if (flowThread && (flowThreadState() == flowThread->flowThreadState()))
> 
> What's this change for?

Assume you have a region-based multicolumn flow thread inside a named flow and you have the multi-column flow thread set as the current flow thread. Now suppose you want to compute borderBoxRectInRegion for the multicolumnflowthread and the region being the rendermulticolumnset. When you ask for containingBlock renderBoxRegionInfo, you go out of rendermulticolumnthread boundary and for these boxes, flowThreadContainingBlock() will return the wrong result.

There are some possible solutions to this problem:
* the check above, which ensures that when you are in the middle of layout and you cross the flow thread boundary, you still get the right result
* add a check in RenderBox::renderBoxRegionInfo so that we return 0 if the flowThreadContainingBlock flowThreadState is different than the box flowThreadState

[Andrei Bucur]

Comment on attachment 227044 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 227044 [details]
Patch

Clearing flags on attachment: 227044

Committed r165890: <http://trac.webkit.org/changeset/165890>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.