Bug 130388

Summary: [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
Product: WebKit Reporter: Alberto Garcia <berto>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Alberto Garcia
Reported 2014-03-18 03:01:56 PDT
This happens because the whole check in shouldRemoveCMakeCache() is performed before the build directory is created, so a fresh build prints this error message: print() on closed filehandle CACHED_ARGUMENTS at Tools/Scripts/webkitdirs.pm line 1943.
Attachments
Patch (1.50 KB, patch)
2014-03-18 03:03 PDT, Alberto Garcia 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2014-03-18 03:03:38 PDT
Created attachment 227020 [details] Patch
Sergio Villar Senin
Comment 2 2014-03-18 06:07:30 PDT
Comment on attachment 227020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227020&action=review r=me > Tools/ChangeLog:7 > + Mind adding a short description of what was happening here?
Alberto Garcia
Comment 3 2014-03-18 06:46:39 PDT
(In reply to comment #2) > > Tools/ChangeLog:7 > > + > > Mind adding a short description of what was happening here? It's already included :) Committed r165809: <http://trac.webkit.org/changeset/165809>
Note You need to log in before you can comment on or make changes to this bug.