Bug 130388

Summary:

[GTK] [CMake] build-webkit-options.txt is not generated during a fresh build

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, dbates, svillar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	svillar: review+

Description Alberto Garcia 2014-03-18 03:01:56 PDT

This happens because the whole check in shouldRemoveCMakeCache() is performed before the build directory is created, so a fresh build prints this error message:

print() on closed filehandle CACHED_ARGUMENTS at Tools/Scripts/webkitdirs.pm line 1943.

Comment 1 Alberto Garcia 2014-03-18 03:03:38 PDT

Created attachment 227020 [details]
Patch

Comment 2 Sergio Villar Senin 2014-03-18 06:07:30 PDT

Comment on attachment 227020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227020&action=review

r=me

> Tools/ChangeLog:7
> +

Mind adding a short description of what was happening here?

Comment 3 Alberto Garcia 2014-03-18 06:46:39 PDT

(In reply to comment #2)
> > Tools/ChangeLog:7
> > +
> 
> Mind adding a short description of what was happening here?

It's already included :)

Committed r165809: <http://trac.webkit.org/changeset/165809>