Bug 130382

Summary:

[iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for computing the general unobscuredRect, only use it for centering

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Benjamin Poulain 2014-03-17 20:18:52 PDT

[iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for computing the general unobscuredRect, only use it for centering

Comment 1 Benjamin Poulain 2014-03-17 20:20:28 PDT

Created attachment 227003 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-03-17 22:28:39 PDT

Comment on attachment 227003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227003&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:632
> +- (CGRect)_unobscuredContentRectIncludingKeyboard

This name is confusing. Does the unobscuring include or exclude the keyboard?

Comment 3 Benjamin Poulain 2014-03-19 14:55:44 PDT

Committed r165924: <http://trac.webkit.org/changeset/165924>