Bug 130381

Summary: Update RegExp Tracing code
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch kling: review+

Description Michael Saboff 2014-03-17 18:35:03 PDT
The regular expression tracing code has experienced a little bit rot.  It needs to be updated to be useful.
Comment 1 Michael Saboff 2014-03-18 10:23:04 PDT
Created attachment 227068 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-18 10:24:27 PDT
Attachment 227068 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/RegExp.h:120:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/runtime/RegExp.h:121:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/runtime/RegExp.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/runtime/RegExp.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-03-18 13:08:47 PDT
Comment on attachment 227068 [details]
Patch

r=me
Comment 4 Michael Saboff 2014-03-18 16:55:04 PDT
Committed r165855: <http://trac.webkit.org/changeset/165855>