Bug 130381

Summary:

Update RegExp Tracing code

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	kling: review+

Michael Saboff

Reported 2014-03-17 18:35:03 PDT

The regular expression tracing code has experienced a little bit rot. It needs to be updated to be useful.

Attachments
Patch (9.42 KB, patch) 2014-03-18 10:23 PDT, Michael Saboff	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2014-03-18 10:23:04 PDT

Created attachment 227068 [details] Patch

WebKit Commit Bot

Comment 2 2014-03-18 10:24:27 PDT

Attachment 227068 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/RegExp.h:120: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/runtime/RegExp.h:121: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/runtime/RegExp.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/runtime/RegExp.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 4 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2014-03-18 13:08:47 PDT

Comment on attachment 227068 [details] Patch r=me

Michael Saboff

Comment 4 2014-03-18 16:55:04 PDT

Committed r165855: <http://trac.webkit.org/changeset/165855>

Note You need to log in before you can comment on or make changes to this bug.