Bug 130377

Summary: Web Inspector: sourceMapResourceLoaded expects statusCode parameter
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-03-17 18:05:11 PDT
Harmless, but explicitly provide a status code to our manual call of sourceMapResourceLoaded.
Comment 1 Joseph Pecoraro 2014-03-17 18:07:46 PDT
Created attachment 226992 [details]
[PATCH] Proposed Fix

Harmless, but nice cleanup.

Context:
...
82:        function sourceMapResourceLoaded(error, body, mimeType, statusCode)
83-        {
84-            const base64encoded = false;
85-
86-            if (error || statusCode >= 400) {
87-                this.markAsFailed();
...

js> undefined >= 400
false
Comment 2 WebKit Commit Bot 2014-03-18 07:34:08 PDT
Comment on attachment 226992 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 226992

Committed r165811: <http://trac.webkit.org/changeset/165811>
Comment 3 WebKit Commit Bot 2014-03-18 07:34:10 PDT
All reviewed patches have been landed.  Closing bug.