Summary: | [WK2] Pass ranges over IPC in a cross-platform manner | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, commit-queue, darin, enrica | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-03-17 18:00:34 PDT
Created attachment 226991 [details]
proposed patch
Attachment 226991 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/EditingRange.h:64: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 226991 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=226991&action=review > Source/WebKit2/Shared/EditingRange.h:67 > + if (location != NSNotFound) > + return NSMakeRange(location, length); > + else > + return NSMakeRange(NSNotFound, 0); if (location == notFound) return NSMakeRange(NSNotFound, 0); return NSMakeRange(location, length); Committed <http://trac.webkit.org/r165823>. |