Summary: | WebKit2 SPI to disable remote inspection on a WKWebView / WKPage | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, joepeck, mitz, timothy | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-03-17 17:00:21 PDT
Created attachment 226985 [details]
[PATCH] Proposed Fix
Comment on attachment 226985 [details]
[PATCH] Proposed Fix
Dan Bernstein raised a comment on IRC that this state (allowsRemoteInspection) should be part of the WebProcessCreationParameters so that if a web process crashed it would be restored with the same state. Sounds like a legit issue. r- on this iteration while I address that.
Created attachment 227081 [details]
[PATCH] Proposed Fix
Comment on attachment 227081 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=227081&action=review > Source/WebKit2/UIProcess/API/C/WKPage.cpp:1650 > +#else > + UNUSED_PARAM(page); > +#endif This should return false in the #else to compile on ports that do not have ENABLE(REMOTE_INSPECTOR). Created attachment 227082 [details]
[PATCH] Proposed Fix
Attachment 227082 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:75: Missing spaces around = [whitespace/operators] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 227082 [details] [PATCH] Proposed Fix Rejecting attachment 227082 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 227082, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 6822b1a74eefce9d6c55d4a48df52d4549f r165835 = 43a4900917f73f5055ff7f644956617946b670d4 r165836 = bc5c3ab8b4183916054ec60692e7830771dc0baf r165837 = f04ec0f78f120b59e4b84cede3d53dfe61fc99b9 r165838 = 5bf5912f022fc0dc603b7f3cd403f34b838c4619 r165839 = 1bc90ffb97e375fe0360680ffd28d02bd8acf3fa Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/5235785955540992 |