Bug 130365

Summary: Move convertToRange() helper to cross-platform WebPage.cpp
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, enrica
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch thorton: review+

Description Alexey Proskuryakov 2014-03-17 15:14:57 PDT 
convertToRange() is duplicated in Mac and iOS code, and it's really cross-platform.
Comment 1 Alexey Proskuryakov 2014-03-17 15:16:33 PDT 
Created attachment 226970 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-03-17 15:18:18 PDT 
Attachment 226970 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4344:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-03-17 15:29:01 PDT 
Committed <http://trac.webkit.org/r165767>.