Bug 130363

Summary: Add transparent window support back into MiniBrowser
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Simon Fraser (smfr) 2014-03-17 14:53:00 PDT 
Add transparent window support back into MiniBrowser
Comment 1 Simon Fraser (smfr) 2014-03-17 14:53:28 PDT 
Created attachment 226968 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-17 14:54:39 PDT 
Attachment 226968 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-03-17 16:43:54 PDT 
Comment on attachment 226968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84
> +@property (nonatomic, setter=_setDrawsTransparentBackground:)BOOL _drawsTransparentBackground;

spaces around =
Comment 4 Anders Carlsson 2014-03-17 16:43:58 PDT 
Comment on attachment 226968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:257
> +    [[self window] setOpaque:!isTransparent];
> +    [[self window] setHasShadow:!isTransparent];

I think you should use dot notation here.
Comment 5 Tim Horton 2014-03-17 16:44:29 PDT 
Comment on attachment 226968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84
>> +@property (nonatomic, setter=_setDrawsTransparentBackground:)BOOL _drawsTransparentBackground;
> 
> spaces around =

and after the )
Comment 6 Tim Horton 2014-03-17 16:45:08 PDT 
Comment on attachment 226968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:34
> +#import <WebKit2/WKWebViewPrivate.h>
>  #import <WebKit2/WKNavigationDelegate.h>

This doesn't look sorted right.
Comment 7 Tim Horton 2014-03-18 23:49:23 PDT 
I think this landed in http://trac.webkit.org/changeset/165775 and http://trac.webkit.org/changeset/165776