Bug 130355

Summary: Add SPI for getting bundle parameters from the injected bundle
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2014-03-17 13:07:43 PDT 
Add SPI for getting bundle parameters from the injected bundle
Comment 1 Anders Carlsson 2014-03-17 13:09:03 PDT 
Created attachment 226947 [details]
Patch
Comment 2 mitz 2014-03-17 13:28:21 PDT 
Comment on attachment 226947 [details]
Patch

>+    _parameters = adoptNS([[NSMutableDictionary alloc] initWithDictionary:dictionary]);

Is this better than -mutableCopy?

> 
> #if USE(FOUNDATION)
> OBJC_CLASS NSBundle;
>+OBJC_CLASS NSMutableDictionary;
>+OBJC_CLASS WKWebProcessBundleParameters;

Shouldn’t this be only #if WK_API_ENABLED ?

> 
>+#if PLATFORM(COCOA)
>+    WKWebProcessBundleParameters *bundleParameters();
>+#endif

Ditto.


>+
>+#if PLATFORM(COCOA)
>+    RetainPtr<WKWebProcessBundleParameters> m_bundleParameters;
>+#endif

Ditto.
Comment 3 Anders Carlsson 2014-03-17 13:38:53 PDT 
Committed r165755: <http://trac.webkit.org/changeset/165755>