Bug 130333

Summary:

[EFL] vibration/cancelVibration-during-pattern-vibrating.html is failing after r165598

Product:

WebKit

Reporter:

Krzysztof Wolanski <k.wolanski>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, gyuyoung.kim, jw00.jeong, lucas.de.marchi, ossy, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
apply suggestion	none

Description Krzysztof Wolanski 2014-03-17 06:59:10 PDT

Added setting m_state when calling Vibration::vibrate. It was missing after refactoring Vibration (r165598).

Comment 1 Krzysztof Wolanski 2014-03-17 06:59:58 PDT

Created attachment 226908 [details]
proposed patch

Comment 2 Jinwoo Jeong 2014-03-18 03:42:46 PDT

If there is a timing issue and this patch makes a layout test to pass,
m_state should be set as State::Waiting instead of State::Vibrating.
If m_state is set as State::Vibrating, the first element of m_pattern will be used for waiting time.

Comment 3 Krzysztof Wolanski 2014-03-18 04:38:02 PDT

Created attachment 227034 [details]
apply suggestion

Comment 4 WebKit Commit Bot 2014-03-19 02:18:07 PDT

Comment on attachment 227034 [details]
apply suggestion

Clearing flags on attachment: 227034

Committed r165882: <http://trac.webkit.org/changeset/165882>

Comment 5 WebKit Commit Bot 2014-03-19 02:21:19 PDT

All reviewed patches have been landed.  Closing bug.