Bug 130318

Summary: Reduce use of deprecatedCharacters in WebCore
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 126854    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
none
Patch
none
Patch
none
Patch
none
Patch none

Description Darin Adler 2014-03-16 23:49:36 PDT
Reduce use of deprecatedCharacters in WebCore
Comment 1 Darin Adler 2014-03-17 00:09:32 PDT
Created attachment 226889 [details]
Patch
Comment 2 Andreas Kling 2014-03-17 00:54:01 PDT
Comment on attachment 226889 [details]
Patch

Regressions: Unexpected text-only failures (30)
  editing/execCommand/6355786.html [ Failure ]
  editing/execCommand/findString-2.html [ Failure ]
  editing/execCommand/findString-3.html [ Failure ]
  editing/execCommand/findString-diacriticals.html [ Failure ]
  editing/execCommand/findString.html [ Failure ]
  editing/selection/find-in-text-control.html [ Failure ]
  editing/selection/find-yensign-and-backslash-with-japanese-fonts.html [ Failure ]
  editing/selection/find-yensign-and-backslash.html [ Failure ]
  editing/selection/move-vertically-with-paddings-borders.html [ Failure ]
  editing/text-iterator/count-mark-lineboxes.html [ Failure ]
  editing/text-iterator/count-mark-simple-lines.html [ Failure ]
  editing/text-iterator/findString.html [ Failure ]
  fast/text/find-backwards.html [ Failure ]
  fast/text/find-case-folding.html [ Failure ]
  fast/text/find-diacritical-mark.html [ Failure ]
  fast/text/find-hidden-text.html [ Failure ]
  fast/text/find-kana.html [ Failure ]
  fast/text/find-quotes.html [ Failure ]
  fast/text/find-soft-hyphen.html [ Failure ]
  fast/text/find-spaces.html [ Failure ]
  fast/text/window-find.html [ Failure ]
  fast/transforms/selection-bounds-in-transformed-view.html [ Failure ]
  http/tests/security/contentSecurityPolicy/report-and-enforce.html [ Failure ]
  http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html [ Failure ]
  http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html [ Failure ]
  http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html [ Failure ]
  http/tests/security/contentSecurityPolicy/report-blocked-uri.html [ Failure ]
  http/tests/security/contentSecurityPolicy/report-only-from-header.php [ Failure ]
  http/tests/security/contentSecurityPolicy/report-only.html [ Failure ]
  platform/mac/accessibility/select-text.html [ Failure ]
Comment 3 Darin Adler 2014-03-17 00:55:13 PDT
Heh, loads of test failures. OK, rework this later (next week maybe?).
Comment 4 Darin Adler 2014-03-17 09:28:45 PDT
Created attachment 226927 [details]
Patch
Comment 5 Darin Adler 2014-03-17 09:30:37 PDT
Created attachment 226928 [details]
Patch
Comment 6 Darin Adler 2014-03-17 09:32:52 PDT
Tests were failing because of incorrect lifetime for unconverted characters in SearchBuffer in TextIterator.cpp. Compilation was failing on GTK and EFL because of missing include in SmartReplace.cpp. Compilation was failing on Windows because of code in file DataURL.cpp.

Uploading a patch soon that fixes all these issues.
Comment 7 Darin Adler 2014-03-17 09:35:19 PDT
Created attachment 226929 [details]
Patch
Comment 8 Build Bot 2014-03-17 12:11:30 PDT
Comment on attachment 226929 [details]
Patch

Attachment 226929 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6704781540196352

New failing tests:
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
http/tests/security/contentSecurityPolicy/report-only-from-header.php
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
http/tests/security/contentSecurityPolicy/report-and-enforce.html
http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
Comment 9 Build Bot 2014-03-17 12:11:33 PDT
Created attachment 226944 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-03-17 13:15:17 PDT
Comment on attachment 226929 [details]
Patch

Attachment 226929 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6647082949541888

New failing tests:
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
http/tests/security/contentSecurityPolicy/report-only-from-header.php
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
http/tests/security/contentSecurityPolicy/report-and-enforce.html
http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
Comment 11 Build Bot 2014-03-17 13:15:19 PDT
Created attachment 226949 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 Build Bot 2014-03-17 13:34:48 PDT
Comment on attachment 226929 [details]
Patch

Attachment 226929 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5840857458540544

New failing tests:
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
http/tests/security/contentSecurityPolicy/report-only-from-header.php
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
http/tests/security/contentSecurityPolicy/report-and-enforce.html
http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
Comment 13 Build Bot 2014-03-17 13:34:51 PDT
Created attachment 226954 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 14 Build Bot 2014-03-17 14:16:19 PDT
Comment on attachment 226929 [details]
Patch

Attachment 226929 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5655147636064256

New failing tests:
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
http/tests/security/contentSecurityPolicy/report-only-from-header.php
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
http/tests/security/contentSecurityPolicy/report-and-enforce.html
http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
Comment 15 Build Bot 2014-03-17 14:16:21 PDT
Created attachment 226964 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 16 Darin Adler 2014-03-17 20:52:18 PDT
Created attachment 227007 [details]
Patch
Comment 17 Darin Adler 2014-03-18 07:26:37 PDT
Created attachment 227047 [details]
Patch
Comment 18 Darin Adler 2014-03-18 07:46:32 PDT
Created attachment 227048 [details]
Patch
Comment 19 Darin Adler 2014-03-18 09:25:55 PDT
Created attachment 227058 [details]
Patch
Comment 20 Darin Adler 2014-03-18 09:33:01 PDT
Phew, think I finally got there. On the 8th try! Someone, please review?
Comment 21 Andreas Kling 2014-03-18 14:26:40 PDT
Comment on attachment 227058 [details]
Patch

r=me

I was trying to come up with something we could do to take advantage of knowing that the empty WTF::String is always 8-bit, but I got nothing.
Comment 22 WebKit Commit Bot 2014-03-18 14:58:12 PDT
Comment on attachment 227058 [details]
Patch

Clearing flags on attachment: 227058

Committed r165848: <http://trac.webkit.org/changeset/165848>
Comment 23 WebKit Commit Bot 2014-03-18 14:58:17 PDT
All reviewed patches have been landed.  Closing bug.