Summary: | Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-ews | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2014-03-16 13:19:15 PDT
Created attachment 226857 [details]
Patch
Comment on attachment 226857 [details]
Patch
I don’t think these includes should be inside #if statements. I also think it’s a little strange that we include <cstdio> rather than <stdio.h> since we call the function fprintf, not std::fprintf.
Comment on attachment 226857 [details] Patch Clearing flags on attachment: 226857 Committed r165732: <http://trac.webkit.org/changeset/165732> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 226857 [details]) > I don’t think these includes should be inside #if statements. I also think it’s a little strange that we include <cstdio> rather than <stdio.h> since we call the function fprintf, not std::fprintf. Forgot to address this before landing, but did address it in r165736. http://trac.webkit.org/changeset/165736 Maybe we should change those printfs to use WTFLogAlways. |