Bug 130305

Summary: Remove all deprecatedCharacters use from WebKit framework
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 126854    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch kling: review+

Darin Adler
Reported 2014-03-16 11:11:40 PDT
Remove all deprecatedCharacters use from WebKit
Attachments
Patch (24.95 KB, patch)
2014-03-16 11:19 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (24.95 KB, patch)
2014-03-16 11:37 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (24.89 KB, patch)
2014-03-16 12:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (24.90 KB, patch)
2014-03-16 14:31 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-03-16 11:19:09 PDT
Created attachment 226845 [details] Patch
Darin Adler
Comment 2 2014-03-16 11:22:27 PDT
Patch does not deal with ios/Misc/WebNSStringDrawing.mm but deals with all the rest.
Anders Carlsson
Comment 3 2014-03-16 11:30:34 PDT
Comment on attachment 226845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226845&action=review > Source/WebKit/win/WebHistory.cpp:568 > + for (auto& url = m_entriesByURL.keys()) :, not =
Darin Adler
Comment 4 2014-03-16 11:37:27 PDT
Created attachment 226847 [details] Patch
Darin Adler
Comment 5 2014-03-16 12:48:48 PDT
Created attachment 226853 [details] Patch
Darin Adler
Comment 6 2014-03-16 14:31:43 PDT
Created attachment 226860 [details] Patch
Darin Adler
Comment 7 2014-03-16 14:32:06 PDT
Patch ready for review now.
Andreas Kling
Comment 8 2014-03-16 19:28:03 PDT
Comment on attachment 226860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226860&action=review r=me > Source/WebKit/win/DOMCoreClasses.cpp:1261 > + // FIXME: This leaks. Delete this whole function to get rid of the leak. Oof.
Darin Adler
Comment 9 2014-03-16 19:45:23 PDT
Committed r165715: <http://trac.webkit.org/changeset/165715>
Note You need to log in before you can comment on or make changes to this bug.