Bug 130305

Summary: Remove all deprecatedCharacters use from WebKit framework
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 126854    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch kling: review+

Description Darin Adler 2014-03-16 11:11:40 PDT 
Remove all deprecatedCharacters use from WebKit
Comment 1 Darin Adler 2014-03-16 11:19:09 PDT 
Created attachment 226845 [details]
Patch
Comment 2 Darin Adler 2014-03-16 11:22:27 PDT 
Patch does not deal with ios/Misc/WebNSStringDrawing.mm but deals with all the rest.
Comment 3 Anders Carlsson 2014-03-16 11:30:34 PDT 
Comment on attachment 226845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226845&action=review

> Source/WebKit/win/WebHistory.cpp:568
> +    for (auto& url = m_entriesByURL.keys())

:, not =
Comment 4 Darin Adler 2014-03-16 11:37:27 PDT 
Created attachment 226847 [details]
Patch
Comment 5 Darin Adler 2014-03-16 12:48:48 PDT 
Created attachment 226853 [details]
Patch
Comment 6 Darin Adler 2014-03-16 14:31:43 PDT 
Created attachment 226860 [details]
Patch
Comment 7 Darin Adler 2014-03-16 14:32:06 PDT 
Patch ready for review now.
Comment 8 Andreas Kling 2014-03-16 19:28:03 PDT 
Comment on attachment 226860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226860&action=review

r=me

> Source/WebKit/win/DOMCoreClasses.cpp:1261
> +    // FIXME: This leaks. Delete this whole function to get rid of the leak.

Oof.
Comment 9 Darin Adler 2014-03-16 19:45:23 PDT 
Committed r165715: <http://trac.webkit.org/changeset/165715>