Summary: | Add CompareStrictEq(StringIdent:, NotStringVar:) and CompareStrictEq(String:, Untyped:) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | barraclough, ggaren, kling, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, sam | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | 130449 | ||||||||||||||
Bug Blocks: | 112840 | ||||||||||||||
Attachments: |
|
Description
Filip Pizlo
2014-03-15 23:14:07 PDT
Created attachment 226867 [details]
work in progress
Created attachment 226868 [details]
moar!
I'm using this as an opportunity to add is-cell/is-not-cell/is-other/is-not-other branch abstractions to deduplicate more 64-bit/32-bit code. Created attachment 226876 [details]
getting there
I wrote all of the DFG code, but there is still some FTL code to write.
Created attachment 227011 [details]
basically done
Created attachment 227089 [details]
the patch
Comment on attachment 227089 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=227089&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3859 > + JITCompiler::JumpList fastSlow; fastFalse Landed in http://trac.webkit.org/changeset/165842 (In reply to comment #8) > Landed in http://trac.webkit.org/changeset/165842 It caused regression on 32 bit x86 - https://bugs.webkit.org/show_bug.cgi?id=130449 |