Bug 130294

Summary: Move BorderEdge class to its own file.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, rakuco, sergio, simon.fraser, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2014-03-15 10:22:25 PDT
This is in preparation to have better encapsulation for border box decoration painting.
Attachments
Patch (42.60 KB, patch)
2014-03-15 13:04 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (43.07 KB, patch)
2014-03-15 19:50 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-03-15 13:04:45 PDT
Created attachment 226826 [details] Patch
Sam Weinig
Comment 2 2014-03-15 18:33:15 PDT
Comment on attachment 226826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review > Source/WebCore/rendering/BorderEdge.h:49 > + BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio); I wonder how much sense it makes to pass Color by reference (rather than by value) these days.
alan
Comment 3 2014-03-15 18:51:35 PDT
(In reply to comment #2) > (From update of attachment 226826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review > > > Source/WebCore/rendering/BorderEdge.h:49 > > + BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio); > > I wonder how much sense it makes to pass Color by reference (rather than by value) these days. Good point. I'll make that change.
alan
Comment 4 2014-03-15 19:50:08 PDT
Created attachment 226830 [details] Patch
alan
Comment 5 2014-03-15 19:50:25 PDT
Comment on attachment 226830 [details] Patch EWS testing.
WebKit Commit Bot
Comment 6 2014-03-15 21:57:31 PDT
Comment on attachment 226830 [details] Patch Clearing flags on attachment: 226830 Committed r165689: <http://trac.webkit.org/changeset/165689>
WebKit Commit Bot
Comment 7 2014-03-15 21:57:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.