| Summary: | Move BorderEdge class to its own file. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bunhere, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, rakuco, sergio, simon.fraser, webkit-ews | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2014-03-15 10:22:25 PDT
Created attachment 226826 [details]
Patch
Comment on attachment 226826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review > Source/WebCore/rendering/BorderEdge.h:49 > + BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio); I wonder how much sense it makes to pass Color by reference (rather than by value) these days. (In reply to comment #2) > (From update of attachment 226826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226826&action=review > > > Source/WebCore/rendering/BorderEdge.h:49 > > + BorderEdge(LayoutUnit edgeWidth, const Color& edgeColor, EBorderStyle edgeStyle, bool edgeIsTransparent, bool edgeIsPresent, float devicePixelRatio); > > I wonder how much sense it makes to pass Color by reference (rather than by value) these days. Good point. I'll make that change. Created attachment 226830 [details]
Patch
Comment on attachment 226830 [details]
Patch
EWS testing.
Comment on attachment 226830 [details] Patch Clearing flags on attachment: 226830 Committed r165689: <http://trac.webkit.org/changeset/165689> All reviewed patches have been landed. Closing bug. |