Bug 130292

Summary: [WebGL] Broken WEBGL_compressed_texture_pvrtc extension support
Product: WebKit Reporter: Byungseon(Sun) Shin <sun.shin>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, dongseong.hwang, esprehn+autocc, gyuyoung.kim, joone, kondapallykalyan, mrobinson, noam, roger_fong, simon.fraser, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Byungseon(Sun) Shin 2014-03-15 07:28:51 PDT 
WebGLRenderingContext::getExtension of WEBGL_compressed_texture_pvrtc extension returns always null.
Comment 1 Byungseon Shin 2014-03-15 07:41:38 PDT 
Created attachment 226819 [details]
Patch
Comment 2 Dongseong Hwang 2014-03-18 23:19:56 PDT 
non-reviewer lgtm
smfr@, could you have a chance to review?
Comment 3 Dean Jackson 2014-03-19 17:13:59 PDT 
Comment on attachment 226819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226819&action=review

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=130292
> +
> +        Reviewed by NOBODY (OOPS!).

Please add something like "We were not returning the extension from the function." as an explanation.
Comment 4 Byungseon Shin 2014-03-19 17:24:38 PDT 
Created attachment 227238 [details]
Patch
Comment 5 WebKit Commit Bot 2014-03-19 20:13:19 PDT 
Comment on attachment 227238 [details]
Patch

Clearing flags on attachment: 227238

Committed r165943: <http://trac.webkit.org/changeset/165943>
Comment 6 WebKit Commit Bot 2014-03-19 20:13:26 PDT 
All reviewed patches have been landed.  Closing bug.