Summary: | Web Inspector: AXI: crash when inspecting "bar" text node in getAccessibilityPropertiesForNode layout test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||
Component: | Web Inspector | Assignee: | James Craig <jcraig> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dpino, graouts, jcraig, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
James Craig
2014-03-14 23:07:12 PDT
Looks like this was a regression from bug 129779. toElement was being called on non-element nodes including text nodes and document nodes. A simple conditional using node->isElementNode() seems to resolve the issue. Patch coming shortly. Created attachment 227840 [details]
patch
The WebCore fix is straightforward. The layout test result diff is obvious, but the layout test source diff is a little large. Among other things I had to rearrange things to reuse the logger on the non-element #document node which was previously specified in a element-only loop.
Comment on attachment 227840 [details] patch Clearing flags on attachment: 227840 Committed r166295: <http://trac.webkit.org/changeset/166295> All reviewed patches have been landed. Closing bug. |