Bug 130284

Summary: Rewrite WebHTMLConverter::_getComputedFloat in C++
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, enrica, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 130274    
Bug Blocks: 130227, 130287    
Attachments:
Description Flags
Patch kling: review+

Ryosuke Niwa
Reported 2014-03-14 21:39:21 PDT
_getComputedFloat should be rewritten in C++ for performance.
Attachments
Patch (7.63 KB, patch)
2014-03-14 21:42 PDT, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-03-14 21:42:26 PDT
Created attachment 226805 [details] Patch
Andreas Kling
Comment 2 2014-03-15 14:42:25 PDT
Comment on attachment 226805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226805&action=review > Source/WebCore/platform/mac/HTMLConverter.mm:769 > + if (Node* parent = node.parentNode()) This is really a ContainerNode*. > Source/WebCore/platform/mac/HTMLConverter.mm:802 > + if (Node* parent = node.parentNode()) This is really a ContainerNode*.
Ryosuke Niwa
Comment 3 2014-03-17 18:36:10 PDT
Committed r165786: <http://trac.webkit.org/changeset/165786>
Note You need to log in before you can comment on or make changes to this bug.