Bug 130282

Summary: Make some Module class constructors return PassRef.
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebCore Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch none

Description Jinwoo Song 2014-03-14 20:19:11 PDT
Make the constructor helpers for the following classes return PassRef instead of
PassRefPtr since they will never return null.
 - GamepadList
 - Geolocation
 - NavigatorContentUtils
 - NetworkInfoConnection
 - Notification
 - NotificationCenter
 - DeviceProximityEvent
Comment 1 Jinwoo Song 2014-03-14 21:26:45 PDT
Created attachment 226804 [details]
Patch
Comment 2 Jinwoo Song 2014-03-16 21:48:24 PDT
Created attachment 226879 [details]
patch
Comment 3 Andreas Kling 2014-03-17 00:20:32 PDT
Comment on attachment 226879 [details]
patch

Sweet! r=me
Comment 4 WebKit Commit Bot 2014-03-17 00:53:05 PDT
Comment on attachment 226879 [details]
patch

Clearing flags on attachment: 226879

Committed r165723: <http://trac.webkit.org/changeset/165723>
Comment 5 WebKit Commit Bot 2014-03-17 00:53:11 PDT
All reviewed patches have been landed.  Closing bug.