Bug 130262

Summary:

Web Inspector: Gracefully handle nil name -[JSContext setName:]

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, graouts, joepeck, mhahnenberg, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-03-14 14:09:02 PDT

This was causing a crash. It should behave like the underlying JSGlobalContextSetName and not crash, but just clear out the name in JSGlobalObject.

Attachments
[PATCH] Proposed Fix (3.21 KB, patch) 2014-03-14 14:11 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-03-14 14:10:41 PDT

* TEST: JSContext *ctx = [[JSContext alloc] init]; ctx.name = nil; * CRASH: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.CoreFoundation 0x00007fff8e6deb1f CFStringGetLength + 15 1 com.apple.JavaScriptCore 0x00007fff87e87b54 JSStringCreateWithCFString + 36 2 com.apple.JavaScriptCore 0x00007fff88205ac2 -[JSContext setName:] + 34 3 a.out 0x000000010024df36 main + 102 4 libdyld.dylib 0x00007fff90dcd5c9 start + 1

Joseph Pecoraro

Comment 2 2014-03-14 14:11:42 PDT

Created attachment 226765 [details] [PATCH] Proposed Fix

Mark Hahnenberg

Comment 3 2014-03-14 14:19:25 PDT

Comment on attachment 226765 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 4 2014-03-14 14:29:49 PDT

Comment on attachment 226765 [details] [PATCH] Proposed Fix Clearing flags on attachment: 226765 Committed r165650: <http://trac.webkit.org/changeset/165650>

WebKit Commit Bot

Comment 5 2014-03-14 14:29:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.