| Summary: | Refactor Path to Path2D and remove currentPath | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||||||||||||||||||
| Component: | Canvas | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, cgarcia, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | WebExposed | ||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Dirk Schulze
2014-03-14 06:57:06 PDT
Created attachment 226708 [details]
Patch
Comment on attachment 226708 [details] Patch Attachment 226708 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6234891448483840 New failing tests: js/dom/global-constructors-attributes.html Created attachment 226716 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 226708 [details] Patch Attachment 226708 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5306108528820224 New failing tests: js/dom/global-constructors-attributes.html Created attachment 226718 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 226722 [details]
Patch
Comment on attachment 226722 [details] Patch Attachment 226722 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6110487183884288 New failing tests: js/dom/global-constructors-attributes.html Created attachment 226732 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 226722 [details] Patch Attachment 226722 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5204266264297472 New failing tests: js/dom/global-constructors-attributes.html Created attachment 226737 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 226722 [details] Patch Attachment 226722 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5145496616173568 New failing tests: js/dom/global-constructors-attributes.html Created attachment 226750 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 226722 [details] Patch Attachment 226722 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4896682181394432 New failing tests: js/dom/global-constructors-attributes.html Created attachment 226755 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 226757 [details]
Patch
I fixed you expectation files Mac ML. Please stay cool!
Comment on attachment 226757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226757&action=review > LayoutTests/fast/canvas/script-tests/canvas-clip-path.js:18 > + if (!data.length) > + return true; > + var c = {r:0,g:0,b:0,a:0}; > + for (var i = 0; i < data.length; i += 4) { > + c.r += data[i]; > + c.g += data[i+1]; > + c.b += data[i+2]; > + c.a += data[i+3]; > + } > + if (refColor.r == Math.round(c.r/data.length*4) > + && refColor.g == Math.round(c.g/data.length*4) > + && refColor.b == Math.round(c.b/data.length*4) > + && refColor.a == Math.round(c.a/data.length*4)) > + return true; > + return false; So much indent!! > LayoutTests/fast/canvas/script-tests/canvas-stroke-path.js:19 > +function areaColor(data, refColor) { > + if (!data.length) > + return true; > + var c = {r:0,g:0,b:0,a:0}; > + for (var i = 0; i < data.length; i += 4) { > + c.r += data[i]; > + c.g += data[i+1]; > + c.b += data[i+2]; > + c.a += data[i+3]; > + } > + if (refColor.r == Math.round(c.r/data.length*4) > + && refColor.g == Math.round(c.g/data.length*4) > + && refColor.b == Math.round(c.b/data.length*4) > + && refColor.a == Math.round(c.a/data.length*4)) > + return true; > + return false; > +} So much indent here too! > Source/WebCore/html/canvas/CanvasRenderingContext2D.h:141 > + void fill(DOMPath* , const String& winding = "nonzero"); > + void stroke(DOMPath*); > + void clip(DOMPath* , const String& winding = "nonzero"); Nit: extra space between * and , Created attachment 226762 [details]
Patch for landing
Created attachment 226764 [details]
Patch for landing... for real this time
Comment on attachment 226764 [details] Patch for landing... for real this time Clearing flags on attachment: 226764 Committed r165651: <http://trac.webkit.org/changeset/165651> All reviewed patches have been landed. Closing bug. |