Bug 130220

Summary: webkit-patch land shouldn't add a reviewer for unreviewed build fixes
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, evab.u-szeged, glenn, joepeck, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2014-03-13 18:29:53 PDT
If I put unreviewed in the non-bug title (not in the typical Reviewed By... place), it shouldn't try to pull a reviewer from any subsequently linked bugzilla bugs.
Attachments
Patch (3.56 KB, patch)
2014-03-18 08:53 PDT, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-03-13 18:32:48 PDT
Why include a bugzilla bug at all? I would include an r#### and say this is a follow-up to that.
Csaba Osztrogonác
Comment 2 2014-03-14 07:27:02 PDT
It's super easy to fix it. This feature was added by http://trac.webkit.org/changeset/121873 , because it happened many times the developer accidentally removed the "reviewed by nobody oops" line. We only need to add one more check for "unreviewed/not reviewed" for this line: "if not found_nobody and not reviewer_text:" in changelog.py
Csaba Osztrogonác
Comment 3 2014-03-14 07:29:29 PDT
cc-ing Éva, she hacked this part of webkitpy recently, maybe she is interested in it.
Éva Balázsfalvi
Comment 4 2014-03-17 08:29:11 PDT
Sounds interesting, I'll check it tomorrow.
Éva Balázsfalvi
Comment 5 2014-03-18 08:53:08 PDT
Created attachment 227054 [details] Patch
Csaba Osztrogonác
Comment 6 2014-03-18 10:58:59 PDT
Comment on attachment 227054 [details] Patch r=me
WebKit Commit Bot
Comment 7 2014-03-18 11:30:44 PDT
Comment on attachment 227054 [details] Patch Clearing flags on attachment: 227054 Committed r165824: <http://trac.webkit.org/changeset/165824>
WebKit Commit Bot
Comment 8 2014-03-18 11:30:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.