Bug 130218

Summary: The viewport code should not depend on WebKitSystemInterface
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Benjamin Poulain 2014-03-13 17:03:37 PDT 
The viewport code should not depend on WebKitSystemInterface
Comment 1 Benjamin Poulain 2014-03-13 17:07:18 PDT 
Created attachment 226630 [details]
Patch
Comment 2 Tim Horton 2014-03-13 17:10:36 PDT 
Comment on attachment 226630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226630&action=review

> Source/WebCore/page/ChromeClient.h:179
> +    virtual FloatSize viewportScreenSize() const { return const_cast<ChromeClient*>(this)->windowRect().size(); }

:| const_cast!
Comment 3 Benjamin Poulain 2014-03-13 17:21:54 PDT 
Comment on attachment 226630 [details]
Patch

Clearing flags on attachment: 226630

Committed r165577: <http://trac.webkit.org/changeset/165577>
Comment 4 Benjamin Poulain 2014-03-13 17:21:56 PDT 
All reviewed patches have been landed.  Closing bug.