Web Inspector: Add a new layout test for better coverage of accessibility "focused" in inspector-protocol DOM.getAccessibilityPropertiesForNode

• Component: Web Inspector
• Status: REOPENED ---

[James Craig]

Web Inspector: Add a new layout test for better coverage of accessibility "focused" in inspector-protocol DOM.getAccessibilityPropertiesForNode

Since "focused" is so dependent on user state, I was thinking something that would load up various focusables:

native links
native form elements (text, button, checkbox, textarea)
contenteditable region
also a few ARIA controls with tabindex values of 0, -1, etc.

Cycle through the different focused states on each control and verify the focused output from DOM.getAccessibilityPropertiesForNode is expected. Might also want to try focusing something that is not focusable (e.g. div:not([tabindex])) and make sure it fails.

Note that native links and buttons are not user focusable (with the Tab key) by default in Safari, but they should always remain "focusable" as far as the accessibility APIs are concerned.

[James Craig]

Diego, would you like to take this one since you worked on the focused/focusable bits? If not, kick it back to unassigned and I'll get to it eventually.

[Diego Pino]

(In reply to comment #1)
> Diego, would you like to take this one since you worked on the focused/focusable bits? If not, kick it back to unassigned and I'll get to it eventually.

Yes sure, nice.

[Diego Pino]

Created attachment 226729 [details]
Patch

[Diego Pino]

I tried to add a non-focusable element and focus on it, with the expectation that focused were false, but what actually happened was that I got a protocol error:

PROTOCOL ERROR: {"code":-32000,"message":"Element is not focusable"}

That means that DOM.focus cannot focus a non-focusable element, and that's the reason why there's no test with "focused: false".

[Timothy Hatcher]

Comment on attachment 226729 [details]
Patch

The result might need rebaselined for new properties.

[Radar WebKit Bug Importer]

<rdar://problem/16357755>

[Diego Pino]

Created attachment 227654 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 227654 [details]
Patch

Rejecting attachment 227654 [details] from commit-queue.

New failing tests:
inspector-protocol/dom/getAccessibilityPropertiesForNode-focused.html
Full output: http://webkit-queues.appspot.com/results/4766140945399808

[WebKit Commit Bot]

Created attachment 227815 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227654 [details]
Patch

Attachment 227654 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4668046509604864

New failing tests:
inspector-protocol/dom/getAccessibilityPropertiesForNode-focused.html

[Build Bot]

Created attachment 227856 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227654 [details]
Patch

Attachment 227654 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4707749187289088

New failing tests:
inspector-protocol/dom/getAccessibilityPropertiesForNode-focused.html

[Build Bot]

Created attachment 227859 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227654 [details]
Patch

Attachment 227654 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4610112769490944

New failing tests:
inspector-protocol/dom/getAccessibilityPropertiesForNode-focused.html

[Build Bot]

Created attachment 227866 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Diego Pino]

Created attachment 228132 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 228132 [details]
Patch

Clearing flags on attachment: 228132

Committed r166467: <http://trac.webkit.org/changeset/166467>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This test fails on all or nearly all bots, will roll out.

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector-protocol%2Fdom%2FgetAccessibilityPropertiesForNode-focused.html

[WebKit Commit Bot]

Re-opened since this is blocked by bug 130952

[Diego Pino]

Created attachment 444948 [details]
Patch

[Diego Pino]

Created attachment 445171 [details]
Patch

[Devin Rousso]

Comment on attachment 445171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445171&action=review

> LayoutTests/inspector/dom/getAccessibilityPropertiesForNode_focused.html:129
> +    InspectorProtocol.sendCommand("DOM.getDocument", {}, onGotDocument);

Can we redo this test to be an inspector test (i.e. `InspectorTest`) instead?  We usually prefer that instead of a protocol test (i.e. `InspectorProtocol`) unless the thing being tested is is specific to the nature of the protocol itself, as inspector tests give greater coverage for the thing being tested within the greater Web Inspector instead of standalone.