Bug 130186

Summary: [EFL] Enable TOUCH_SLIDER macro
Product: WebKit Reporter: Byung Jun Kim <bj1987.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, dbates, gyuyoung.kim, gyuyoung.kim, jinwoo7.song, lucas.de.marchi, rakuco, ryuan.choi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Byung Jun Kim 2014-03-13 03:30:13 PDT 
"TOUCH_SLIDER" macro helps the behavior of sliders when TOUCH_EVENT is enabled.
In current, "TOUCH_SLIDER" macro is disabled but "TOUCH_EVENTS" is enabled. 
So we should synchronize "TOUCH_SLIDER" and "TOUCH_EVENTS".
Comment 1 Byung Jun Kim 2014-03-13 23:11:12 PDT 
Created attachment 226651 [details]
Patch
Comment 2 Jinwoo Song 2014-03-13 23:21:30 PDT 
Looks good to me.EFL port needs this feature for supporting touch devices.
Comment 3 Ryuan Choi 2014-03-14 00:09:03 PDT 
Comment on attachment 226651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226651&action=review

> Source/cmake/OptionsEfl.cmake:92
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON)

I think that we should disable ENABLE_TOUCH_SLIDER when ENABLE_TOUCH_EVENTS became OFF.
Comment 4 Byung Jun Kim 2014-03-16 15:54:00 PDT 
Created attachment 226864 [details]
Patch
Comment 5 Ryuan Choi 2014-03-16 18:07:32 PDT 
LGTM.
Comment 6 Gyuyoung Kim 2014-03-16 22:38:48 PDT 
Comment on attachment 226864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226864&action=review

LGTM. r=me.

> ChangeLog:6
> +        Reviewed by Ryuan Choi.

Remove this line. Ryuan is not reviewer yet.
Comment 7 Byung Jun Kim 2014-03-16 22:56:54 PDT 
Created attachment 226884 [details]
Patch
Comment 8 Gyuyoung Kim 2014-03-16 22:58:43 PDT 
If you got already r+, you don't need to request review again. Just upload a patch with "Reviewed by Gyuyoung Kim" and then only request cq?.
Comment 9 Byung Jun Kim 2014-03-16 23:03:13 PDT 
Created attachment 226885 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2014-03-16 23:50:11 PDT 
Comment on attachment 226885 [details]
Patch for landing

Clearing flags on attachment: 226885

Committed r165722: <http://trac.webkit.org/changeset/165722>
Comment 11 WebKit Commit Bot 2014-03-16 23:50:18 PDT 
All reviewed patches have been landed.  Closing bug.