Bug 130172

Summary:

[iOS] Sync media playback with now playing

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, dbates, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none

Description Eric Carlson 2014-03-12 19:28:23 PDT

Pass information about the currently playing media element to MPNowPlayingInfoCenter.

Comment 1 Eric Carlson 2014-03-12 19:52:59 PDT

Created attachment 226569 [details]
Proposed patch.

Comment 2 Jer Noble 2014-03-13 08:49:06 PDT

Comment on attachment 226569 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=226569&action=review

r=me

> Source/WebCore/platform/audio/MediaSessionManager.cpp:157
> -
> +    

Whew, I was worried I wouldn't have a nit!  Ahem, unnecessary whitespace.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:42
> +#import <MediaPlayer/MPRemoteCommand.h>
> +#import <MediaPlayer/MPRemoteCommandCenter.h>
> +#import <MediaPlayer/MPRemoteCommandEvent.h>

It looks like these are unused.  (For now.)

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:71
> +SOFT_LINK_CLASS(MediaPlayer, MPRemoteCommandCenter)

Ditto.

Comment 3 Eric Carlson 2014-03-13 11:25:30 PDT

Committed r165552: https://trac.webkit.org/r165552