Summary: | Web Inspector: Fix multiple console.assert stripping issues | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-03-12 16:42:55 PDT
With the new warning, and a script to process each JS file of ours, this is the output I see: shell> ./Scripts/remove-console-asserts-dryrun.rb DOMTreeManager.js: WARNING: console.assert inside control flow statement without braces on line: 556: console.assert(contentFlow.contentNodes[i].id === flowPayload.content[i]); DataGrid.js: WARNING: Multi-line console.assert on line 775: console.assert(!child.isPlaceholderNode, "Shouldn't delete the placeholder node.") If the line ends in a ')' then its likely not multi-line and just a missing semicolon. Changed that warning to: DataGrid.js: WARNING: console.assert missing trailing semicolon on line 775: console.assert(!child.isPlaceholderNode, "Shouldn't delete the placeholder node.") Created attachment 226560 [details]
[PATCH] Proposed Fix
|