| Summary: | Subpixel rendering: Nested layers with subpixel accumulation paint to wrong position. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy, rniwa, simon.fraser, webkit-ews | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 130199 | ||||||||||||||
| Bug Blocks: | 130430 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zalan
2014-03-12 12:50:53 PDT
Created attachment 226551 [details]
Patch
Comment on attachment 226551 [details] Patch Clearing flags on attachment: 226551 Committed r165540: <http://trac.webkit.org/changeset/165540> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 130199 Comment on attachment 226551 [details] Patch Attachment 226551 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6741007710289920 New failing tests: compositing/hidpi-absolute-subpixel-positioned-transformed-elements.html Created attachment 226642 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 226551 [details] Patch Attachment 226551 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4589675771592704 New failing tests: compositing/hidpi-absolute-subpixel-positioned-transformed-elements.html Created attachment 226645 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 227145 [details]
Patch
Comment on attachment 227145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227145&action=review > Source/WebCore/rendering/RenderLayer.cpp:4176 > + // Translate the graphics context to the snapping position to avoid off-device-pixel positing. This works as long as the user defined > + // transform is not producing subpixel results (translate(0.5px, 0.5px) vs. translate(0.7px, 0.7px)) "This works as long as" isn't really adding information here, and it's not clear what "works" means. I'd remove this second sentence. (In reply to comment #10) > (From update of attachment 227145 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227145&action=review > > > Source/WebCore/rendering/RenderLayer.cpp:4176 > > + // Translate the graphics context to the snapping position to avoid off-device-pixel positing. This works as long as the user defined > > + // transform is not producing subpixel results (translate(0.5px, 0.5px) vs. translate(0.7px, 0.7px)) > > "This works as long as" isn't really adding information here, and it's not clear what "works" means. I'd remove this second sentence. Indeed. Thanks for the review. Created attachment 227242 [details]
Patch
Comment on attachment 227242 [details]
Patch
EWS testing.
Comment on attachment 227242 [details] Patch Clearing flags on attachment: 227242 Committed r165963: <http://trac.webkit.org/changeset/165963> All reviewed patches have been landed. Closing bug. |