Summary: | [EFL][WK2] Add NETWORK_PROCESS build option | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||||
Component: | WebKit EFL | Assignee: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco, sergio, webkit-ews | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 110141 | ||||||||||
Attachments: |
|
Description
Michal Pakula vel Rutka
2014-03-12 08:27:37 PDT
Created attachment 226509 [details]
proposed patch
Comment on attachment 226509 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=226509&action=review > ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=13xxxx Bug id is generated as 130131. :) > Source/WebKit2/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=13xxxx Bug id is generated as 130131. (In reply to comment #2) > (From update of attachment 226509 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226509&action=review > > > ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=13xxxx > > Bug id is generated as 130131. :) > > > Source/WebKit2/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=13xxxx > > Bug id is generated as 130131. Sorry I posted work-in-progress patch version... Created attachment 227642 [details]
patch with fixed changelog
Comment on attachment 227642 [details] patch with fixed changelog View in context: https://bugs.webkit.org/attachment.cgi?id=227642&action=review > Source/WebKit2/PlatformEfl.cmake:427 > +if (ENABLE_NETWORK_PROCESS) Should we use ENABLE_NETWORK_PROCESS macro in cmake as well ? Personally I prefer not to use it in cmake, because the file(NetworkMainUnix.cpp) is already guarded by ENABLE(NETWORK_PROCESS). When we use it in cmake, duplicated include directory may be included or it is a little hard to maintain files|include_directories|library. How do you think about this ? (In reply to comment #5) > (From update of attachment 227642 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227642&action=review > > > Source/WebKit2/PlatformEfl.cmake:427 > > +if (ENABLE_NETWORK_PROCESS) > > Should we use ENABLE_NETWORK_PROCESS macro in cmake as well ? Personally I prefer not to use it in cmake, because the file(NetworkMainUnix.cpp) is already guarded by ENABLE(NETWORK_PROCESS). When we use it in cmake, duplicated include directory may be included or it is a little hard to maintain files|include_directories|library. How do you think about this ? OK I will remove this guard. Created attachment 227736 [details]
fixes after review
Comment on attachment 227736 [details] fixes after review Clearing flags on attachment: 227736 Committed r166230: <http://trac.webkit.org/changeset/166230> All reviewed patches have been landed. Closing bug. *** Bug 130126 has been marked as a duplicate of this bug. *** |