Summary: | Web Inspector: vended backend commands file should be generated as part of the build | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | berto, bfulgham, bunhere, cdumez, commit-queue, graouts, gyuyoung.kim, joepeck, mrobinson, rakuco, sergio, timothy, webkit-bug-importer, zan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 130111, 130846 | ||||||||||
Attachments: |
|
Description
BJ Burg
2014-03-11 19:22:03 PDT
Making it depend on WebCore is fine. WebCore will just need to copy the commands into its bundle resources for the WebInspectorUI project to find and copy out. (In reply to comment #1) > Making it depend on WebCore is fine. WebCore will just need to copy the commands into its bundle resources for the WebInspectorUI project to find and copy out. Probably not "bundle resources" but "private headers". If it went to the Resources directory, we might accidentally include the scripts in WebCore.framework/Resources. PrivateHeaders we already use for this kind of thing with code generator scripts, and they are not included in what we ship. Ah, yes that is what I meant. Created attachment 226641 [details]
wip (missing CMake, some GTK bundling magic)
Created attachment 226758 [details]
the patch - missing Win/CMake bits for WebInspectorUI
Created attachment 226791 [details]
patch round 2
Comment on attachment 226791 [details] patch round 2 Clearing flags on attachment: 226791 Committed r165704: <http://trac.webkit.org/changeset/165704> All reviewed patches have been landed. Closing bug. Comment on attachment 226791 [details] patch round 2 View in context: https://bugs.webkit.org/attachment.cgi?id=226791&action=review Late comments. Good stuff! > Source/WebCore/CMakeLists.txt:3023 > + OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebBackendDispatchers.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebBackendDispatchers.h ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebFrontendDispatchers.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebFrontendDispatchers.h ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebTypeBuilders.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebTypeBuilders.h ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWebBackendCommands.js Oops! Good catch on these. > Source/WebInspectorUI/GNUmakefile.am:37 > $(WebInspectorUI)/Localizations/en.lproj/localizedStrings.js \ > + $(shell ls $(GENSOURCES_JAVASCRIPTCORE)/InspectorJSBackendCommands.js) \ > + $(shell ls $(GENSOURCES_WEBCORE)/InspectorWebBackendCommands.js) \ I don't think the "shell ls" is needed for individual files. This could be just like the line above it. This change broke the Windows WebInspector. I'm putting together a fix. |