REGRESSION (r160806): Incorrect cascade order of prefixed and non-prefixed variants of CSS properties box-shadow and background-{clip, origin, size}

• Component: CSS
• Status: RESOLVED FIXED

[Daniel Bates]

Following <http://trac.webkit.org/changeset/160806> (bug #125213) we compute the final value of the CSS properties box-shadow and background-{clip, origin, size} incorrectly when both the prefixed and non-prefixed variants (in order) of these properties appear in same selector definition.
 
Consider the following definition for selector #square:

#square {
    background-image: url(...);
    -webkit-background-size: 128px 32px;
    background-size: 128px 128px;
} 

Then the value of the CSS property background-size will override the value of -webkit-background-size and the background size will be 128px x 128px (by definition of CSS property background-size). But it's 128px x 32px following the patch for bug #125213.

[Daniel Bates]

<rdar://problem/16187037>

[Daniel Bates]

Created attachment 226447 [details]
Patch

[Andreas Kling]

Comment on attachment 226447 [details]
Patch

r=me

[Early Warning System Bot]

Attachment 226447 [details] did not pass style-queue:


ERROR: LayoutTests/fast/css/resources/red-square-in-green-square.png:0:  Have to enable auto props in the subversion config file (/home/ossy/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/ossy/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Committed r165587: <http://trac.webkit.org/changeset/165587>