Bug 130083

Summary: [CSS Grid Layout] Add layout test for anonymous grid items
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch none

Description Manuel Rego Casasnovas 2014-03-11 03:44:52 PDT
It would be nice to have a layout test to prevent regressions in the support of anonymous grid items.

This has been already fixed in Blink and will be ported to WebKit: https://codereview.chromium.org/181183005
Comment 1 Manuel Rego Casasnovas 2014-03-11 03:54:46 PDT
Created attachment 226414 [details]
Patch
Comment 2 Sergio Villar Senin 2014-03-11 04:44:32 PDT
Comment on attachment 226414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226414&action=review

OK I guess it won't harm.

> LayoutTests/ChangeLog:8
> +        Add a layout test to prevent regressions supporting anonymous grid items.

Cou you improve a bit the description? Like mentioning that they don't have document() or node() blablabla
Comment 3 Manuel Rego Casasnovas 2014-03-11 05:44:16 PDT
Created attachment 226419 [details]
Patch

Patch for landing.
Comment 4 WebKit Commit Bot 2014-03-11 06:23:11 PDT
Comment on attachment 226419 [details]
Patch

Clearing flags on attachment: 226419

Committed r165449: <http://trac.webkit.org/changeset/165449>
Comment 5 WebKit Commit Bot 2014-03-11 06:23:13 PDT
All reviewed patches have been landed.  Closing bug.