Bug 130065

Summary: r165414 broke the 32-bit x86 tests: ASSERTION FAILED: result != InvalidIndex @ GPRInfo.h:330
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Description Mark Lam 2014-03-10 19:56:43 PDT 
The assertion failure shows up readily when you run "run-javascriptcore-tests --debug --32-bit".
Comment 1 Filip Pizlo 2014-03-10 19:59:00 PDT 
Looking at it.
Comment 2 Mark Lam 2014-03-10 21:08:07 PDT 
<rdar://problem/16284986>
Comment 3 Mark Lam 2014-03-10 21:11:07 PDT 
There is code in ScratchRegisterAllocator.cpp that is expecting GPRInfo::toIndex() to be able to return InvalidIndex.  Hence, the assertion is invalid.  Ditto for FPRInfo::toIndex().

The fix is to remove the "result != InvalidIndex" assertions.
Comment 4 Mark Lam 2014-03-10 21:15:15 PDT 
Created attachment 226381 [details]
the patch.
Comment 5 Mark Lam 2014-03-10 21:20:08 PDT 
Comment on attachment 226381 [details]
the patch.

Thanks for the review.
Comment 6 Filip Pizlo 2014-03-10 21:24:22 PDT 
Comment on attachment 226381 [details]
the patch.

r=me too
Comment 7 WebKit Commit Bot 2014-03-10 21:48:00 PDT 
Comment on attachment 226381 [details]
the patch.

Clearing flags on attachment: 226381

Committed r165431: <http://trac.webkit.org/changeset/165431>
Comment 8 WebKit Commit Bot 2014-03-10 21:48:03 PDT 
All reviewed patches have been landed.  Closing bug.