Bug 130065

Summary: r165414 broke the 32-bit x86 tests: ASSERTION FAILED: result != InvalidIndex @ GPRInfo.h:330
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2014-03-10 19:56:43 PDT
The assertion failure shows up readily when you run "run-javascriptcore-tests --debug --32-bit".
Attachments
the patch. (3.25 KB, patch)
2014-03-10 21:15 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-03-10 19:59:00 PDT
Looking at it.
Mark Lam
Comment 2 2014-03-10 21:08:07 PDT
<rdar://problem/16284986>
Mark Lam
Comment 3 2014-03-10 21:11:07 PDT
There is code in ScratchRegisterAllocator.cpp that is expecting GPRInfo::toIndex() to be able to return InvalidIndex. Hence, the assertion is invalid. Ditto for FPRInfo::toIndex(). The fix is to remove the "result != InvalidIndex" assertions.
Mark Lam
Comment 4 2014-03-10 21:15:15 PDT
Created attachment 226381 [details] the patch.
Mark Lam
Comment 5 2014-03-10 21:20:08 PDT
Comment on attachment 226381 [details] the patch. Thanks for the review.
Filip Pizlo
Comment 6 2014-03-10 21:24:22 PDT
Comment on attachment 226381 [details] the patch. r=me too
WebKit Commit Bot
Comment 7 2014-03-10 21:48:00 PDT
Comment on attachment 226381 [details] the patch. Clearing flags on attachment: 226381 Committed r165431: <http://trac.webkit.org/changeset/165431>
WebKit Commit Bot
Comment 8 2014-03-10 21:48:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.