Bug 130064

Summary: [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197934
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2014-03-10 19:43:26 PDT
CMake doesn't always rely on pkgconfig to find dependencies and instead looks in well-known locations on the host system. Since we want the JHBuild dependencies to take precendence over any libraries installed on the host system, we need to force CMake to look first in the JHBuild root. The EFL port already has logic for doing this, so we should move this logic and all other shared logic to jhbuildrc_common.py.
Attachments
Patch (4.54 KB, patch)
2014-03-10 20:04 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-03-10 20:04:04 PDT
Created attachment 226375 [details] Patch
Martin Robinson
Comment 2 2014-03-11 08:03:23 PDT
Comment on attachment 226375 [details] Patch Clearing flags on attachment: 226375 Committed r165452: <http://trac.webkit.org/changeset/165452>
Martin Robinson
Comment 3 2014-03-11 08:03:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.