Bug 130047

Summary: Add SPI to run javascript in main frame on WKWebView
Product: WebKit Reporter: Paul Hankes Drielsma <hankesdrielsma>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, mitz
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Paul Hankes Drielsma
Reported 2014-03-10 15:55:31 PDT
Expose runJavascript API to WKWebView via SPI for use in Safari.
Attachments
Patch (2.12 KB, patch)
2014-03-10 16:05 PDT, Paul Hankes Drielsma 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2014-03-11 09:39 PDT, Paul Hankes Drielsma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Paul Hankes Drielsma
Comment 1 2014-03-10 16:05:28 PDT
Created attachment 226347 [details] Patch
mitz
Comment 2 2014-03-10 16:20:55 PDT
Comment on attachment 226347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226347&action=review > Source/WebKit2/ChangeLog:3 > + Add SPI to run javascript in main frame on WKWebView. No need for this. The bug title and URL below suffice. Although this makes for a better title than the bug’s current title. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:856 > + _page->runJavaScriptInMainFrame(scriptString, WebKit::ScriptValueCallback::create([](bool b, WebKit::WebSerializedScriptValue* sv){})); We typically don’t name unused parameters.
Paul Hankes Drielsma
Comment 3 2014-03-11 09:39:40 PDT
Created attachment 226433 [details] Patch
WebKit Commit Bot
Comment 4 2014-03-13 19:02:15 PDT
Comment on attachment 226433 [details] Patch Clearing flags on attachment: 226433 Committed r165591: <http://trac.webkit.org/changeset/165591>
WebKit Commit Bot
Comment 5 2014-03-13 19:02:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.