Summary: | [X86_64] Smaller code for sub_ir when register is accumulator. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | JavaScriptCore | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kling | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2014-03-10 09:43:49 PDT
Created attachment 226308 [details]
Patch
Comment on attachment 226308 [details]
Patch
What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants?
(In reply to comment #2) > (From update of attachment 226308 [details]) > What about the CAN_SIGN_EXTEND_8_32(imm) cases and adding the 8 byte immediate variants? The 8 byte immediate variant adds to AL only, and not the upper part of the accumulator. Oh oops, I was thinking about 8-bit, not 8 byte. From reading the Intel manual, it looks like the "ADD r/m32,imm8" variant is the shortest possible instruction in that path. Comment on attachment 226308 [details] Patch Clearing flags on attachment: 226308 Committed r165391: <http://trac.webkit.org/changeset/165391> All reviewed patches have been landed. Closing bug. |