Bug 13001

Summary: Missing accessibility localized strings cause assertion failure
Product: WebKit Reporter: Andrew Wellington <andrew>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P1    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch
darin: review+
Patch
andrew: review-
Patch darin: review+

Andrew Wellington
Reported 2007-03-07 04:57:45 PST
A number of accessibility strings are missing from Localizable.strings. This means some accessibility functions will cause an assertion failure in WebKit: ASSERTION FAILED: could not find localizable string web area in bundle result != notFound (/Users/andrew/Documents/Coding/WebKit-svn/WebKit/Misc/WebLocalizableStrings.m:57 WebLocalizedString) To trigger this: 1. Load a web page or image in WebKit (eg. http://webkit.org/ ) 2. Open Accessibility Viewer from the Developer tools 3. Hold the mouse over the WebKit window
Attachments
Patch (2.94 KB, patch)
2007-03-07 04:59 PST, Andrew Wellington 		darin: review+
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2007-03-07 15:00 PST, Andrew Wellington 		andrew: review-
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2007-03-07 15:02 PST, Andrew Wellington 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrew Wellington
Comment 1 2007-03-07 04:59:07 PST
Created attachment 13515 [details] Patch
Darin Adler
Comment 2 2007-03-07 06:24:04 PST
Comment on attachment 13515 [details] Patch This should be taken care of by running the script update-webkit-localizable-strings. Is that how you did this? r=me
Mark Rowe (bdash)
Comment 3 2007-03-07 06:49:55 PST
<rdar://problem/5045722>
Andrew Wellington
Comment 4 2007-03-07 15:00:06 PST
Created attachment 13532 [details] Patch *Sigh* I created the previous patch with genstrings even though I had one made with update-webkit-localizable-strings. This one is made with update-webkit-localizable-strings which is the same changes but in a different order :-) Now to file a bug on the problem with svn-create-patch that made me confuse which patch I was using...
Andrew Wellington
Comment 5 2007-03-07 15:00:50 PST
Comment on attachment 13532 [details] Patch Ignore that one, wrong ChangeLog entry. I think I need coffee...
Andrew Wellington
Comment 6 2007-03-07 15:02:47 PST
Created attachment 13533 [details] Patch Now with ChangeLog done right
Darin Adler
Comment 7 2007-03-07 15:08:13 PST
Comment on attachment 13533 [details] Patch r=me
Mark Rowe (bdash)
Comment 8 2007-03-07 18:06:34 PST
Tim Hatcher took care of this in r20037.
Note You need to log in before you can comment on or make changes to this bug.