Summary: | GPRInfo::toIndex should return InvalidIndex for non-temp registers on ARM64 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 112840 | ||||||
Attachments: |
|
Description
Filip Pizlo
2014-03-09 20:08:47 PDT
Created attachment 226276 [details]
the patch
Still running tests to confirm that this is ok.
Comment on attachment 226276 [details]
the patch
Do we need to ASSERT(index <= regT15) in toRegister() to match this?
(In reply to comment #2) > (From update of attachment 226276 [details]) > Do we need to ASSERT(index <= regT15) in toRegister() to match this? I suppose we could add one. I'm not sure how much good it would do, though. Comment on attachment 226276 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/165362 |