| Summary: | Build failure on OpenBSD in gtest | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Landry Breuil <landry> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ajacoutot, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 226220 [details]
Patch
Comment on attachment 226220 [details]
Patch
LGTM, r=me.
Please send this patch to the upstream gtest too not to have
this problem again once gtest is updated in the WebKit repository.
Comment on attachment 226220 [details] Patch Rejecting attachment 226220 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226220, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/ThirdParty/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5137805000835072 It is already partly upstream, cf https://code.google.com/p/googletest/source/browse/trunk/include/gtest/internal/gtest-port.h#328 What's needed for the commit bot to be smart and add the reviewer line to the patch and autoland things ? Is there still manual fiddling to do ? |
CXX Source/ThirdParty/gtest/src/Libraries_libgtest_la-gtest-all.lo In file included from /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:40:0, from /src/WebKit/Source/ThirdParty/gtest/include/gtest/gtest.h:57, from ../../../src/WebKit/Source/ThirdParty/gtest/src/gtest-all.cc:39: /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::IsATTY(int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1349:45: error: 'isatty' was not declared in this scope inline int IsATTY(int fd) { return isatty(fd); } ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::RmDir(const char*)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1355:53: error: 'rmdir' was not declared in this scope inline int RmDir(const char* dir) { return rmdir(dir); } ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::ChDir(const char*)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1377:53: error: 'chdir' was not declared in this scope inline int ChDir(const char* dir) { return chdir(dir); } ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Read(int, void*, unsigned int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1391:46: error: 'read' was not declared in this scope return static_cast<int>(read(fd, buf, count)); ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Write(int, const void*, unsigned int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1394:47: error: 'write' was not declared in this scope return static_cast<int>(write(fd, buf, count)); ^ /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Close(int)': /src/WebKit/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1396:43: error: 'close' was not declared in this scope inline int Close(int fd) { return close(fd); }