Bug 129965 – Use pthread_stackseg_np() to find the stack bounds on OpenBSD

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Landry Breuil]

And add an #ifndef __OpenBSD__ because we have pthread_np.h like FreeBSD but not pthread_attr_get_np()

http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_JavaScriptCore_heap_MachineStackMarker_cpp?rev=1.3

[Landry Breuil]

Created attachment 226210 [details]
Use pthread_stackseg_np on OpenBSD

[Geoffrey Garen]

Comment on attachment 226210 [details]
Use pthread_stackseg_np on OpenBSD

View in context: https://bugs.webkit.org/attachment.cgi?id=226210&action=review

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:356
> +#  ifndef __OpenBSD__

Instead of checking the compiler-provided mangled symbol, you should add an entry for OS(OPENBSD) to wtf/Platform.h, and make it mutually exclusive with OS(NETBSD).

[Landry Breuil]

(In reply to comment #2)
> (From update of attachment 226210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226210&action=review
> 
> > Source/JavaScriptCore/heap/MachineStackMarker.cpp:356
> > +#  ifndef __OpenBSD__
> 
> Instead of checking the compiler-provided mangled symbol, you should add an entry for OS(OPENBSD) to wtf/Platform.h, and make it mutually exclusive with OS(NETBSD).

There's already one in wtf/Platform.h, dunno why i didnt use it..

[Anders Carlsson]

Comment on attachment 226210 [details]
Use pthread_stackseg_np on OpenBSD

Please upload a new patch that uses OS(OPENBSD). Thanks!

[Landry Breuil]

Created attachment 226855 [details]
Use pthread_stackseg_np on OpenBSD

Hand-edited patch for the win! To whoever commits it, please add the 'Reviewed by' line to please the bots...

[Alexey Proskuryakov]

Can you upload a new patch with "Reviewed by Anders Carlsson" in ChangeLog, and mark the patch with cq? flag? In this case, all a committer needs to do is change that to cq+, which is more likely to happen soon than manually landing the patch.

[Alexey Proskuryakov]

Comment on attachment 226855 [details]
Use pthread_stackseg_np on OpenBSD

View in context: https://bugs.webkit.org/attachment.cgi?id=226855&action=review

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:356
> +#  if !OS(OPENBSD)

We normally don't use this kind of indentation for preprocessor. Does this match something else in this file? If no, please change to plain "#if".

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:359
> +#  endif

Ditto.

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:422
> +# if OS(OPENBSD)

Ditto.

[Landry Breuil]

Created attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Ugh. Much easier to contribute to mozilla than to webkit..... such pain dealing with patch bureaucracy.

[WebKit Commit Bot]

Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Rejecting attachment 226946 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Rejecting attachment 226946 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Landry Breuil]

Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

I hate you commit bot.

[Alexey Proskuryakov]

Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

You don't need to ask for review when it's already reviewed.

[WebKit Commit Bot]

Comment on attachment 226946 [details]
Use pthread_stackseg_np on OpenBSD

Clearing flags on attachment: 226946

Committed r166113: <http://trac.webkit.org/changeset/166113>